upkg: Fix missing return statement.

[upkg.git] / src / upkg.c

diff --git a/src/upkg.c b/src/upkg.c
index 0e5a84e6dfe907d9ead33f2920b714129d0aa585..6b48f72c92988277137e0702619bbb1e4d7a9041 100644 (file)
--- a/src/upkg.c
+++ b/src/upkg.c
@@ -262,6 +262,8 @@ static int package_list(GTypeModule *pkg, long parent)
 
                putchar('\n');
        }
+
+       return 0;
 }
 
 static int object_info(GTypeModule *pkg, unsigned long idx)
@@ -314,17 +316,20 @@ static int export(GTypeModule *pkg, GObject *obj, unsigned idx)
        struct upkg *upkg = U_PKG(pkg)->pkg;
        char name[256];
        FILE *of;
+       int rc;
 
-       if (u_object_deserialize(obj, upkg, idx) != 0) {
+       if (U_OBJECT_IS_LOADABLE(obj) && u_object_load(obj) != 0) {
                return -1;
        }
 
-       if (U_OBJECT_IS_LOADABLE(obj) && u_object_load(obj) != 0) {
+       rc = u_object_export_name(obj, name, sizeof name);
+       if (rc <= 0) {
+               /* XXX: We could use a default name here. */
+               fprintf(stderr, "%s: failed to determine export filename.\n",
+                               progname);
                return -1;
        }
 
-       u_object_export_name(obj, name, sizeof name);
-
        printf("exporting ");
        export_print_fullname(pkg, upkg_get_export(upkg, idx));
        printf(" to %s\n", name);
@@ -349,6 +354,29 @@ static int export(GTypeModule *pkg, GObject *obj, unsigned idx)
        return 0;
 }
 
+static int object_export(GTypeModule *pkg, unsigned long idx)
+{
+       struct upkg *upkg = U_PKG(pkg)->pkg;
+       GObject *obj;
+       int ret = -1;
+
+       obj = u_object_new_from_package(upkg, idx);
+       if (!obj) {
+               fprintf(stderr, "%s: failed to load object.\n", progname);
+               return -1;
+       }
+
+       if (!U_OBJECT_IS_EXPORTABLE(obj)) {
+               fprintf(stderr, "%s: object is not exportable.\n", progname);
+               goto out;
+       }
+
+       ret = export(pkg, obj, idx);
+out:
+       g_object_unref(obj);
+       return ret;
+}
+
 int package_export(GTypeModule *pkg)
 {
        struct upkg *upkg = U_PKG(pkg)->pkg;
@@ -365,11 +393,13 @@ int package_export(GTypeModule *pkg)
                }
 
                type = u_object_module_get_class(package, class);
-               if (!type) continue;
+               if (!type)
+                       continue;
 
                obj = g_object_new(type, NULL);
                if (U_OBJECT_IS_EXPORTABLE(obj)) {
-                       if (export(pkg, obj, i) != 0) {
+                       if (u_object_deserialize(obj, upkg, i) != 0
+                           || export(pkg, obj, i) != 0) {
                                ret = -1;
                        }
                }
@@ -440,7 +470,10 @@ static int process_object(int mode, const char *objname)
                ret = package_list(pkg, current+1);
                break;
        case MODE_EXPORT:
-               ret = package_export(pkg);
+               if (current < 0)
+                       ret = package_export(pkg);
+               else
+                       ret = object_export(pkg, current);
                break;
        default:
                abort();