1 2020-08-29 Nuno Silva <nuno.m.ribeiro.silva@tecnico.ulisboa.pt>
3 common: fix infinite loop when getrandom fails
5 Fixes: https://github.com/iputils/iputils/issues/291
7 2020-01-06 Sami Kerola <kerolasa@iki.fi>
9 common: flush streams before closing them
11 On loaded systems slow tty can give false positive exit failure due pending
12 bytes. Flush the streams that hopefully makes these problems less likely.
14 Reference: https://github.com/iputils/iputils/commit/4655ecc5105c383669ef529f21f3344f99e7372f#commitcomment-36628770
16 2019-11-24 Sami Kerola <kerolasa@iki.fi>
18 rdisc / ninfod: fix format string warning
20 warning: format string is not a string literal [-Wformat-nonliteral]
22 The above was reported for rdisc.c lines 210 and 212, and ninfod/ninfod.c
25 Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
27 2019-10-31 Philipp Kammerer <kammerer@b1-systems.de>
29 doc: Proofreading rarpd.xml
31 A few suggestions to make the manpage more easy to read
33 2019-10-17 Maciej Żenczykowski <maze@google.com>
35 iputils_common.h: fix missing #include <sys/time.h>
38 In file included from ping/ping6_common.c:61:
39 iputils_common.h:63:32: error: declaration of 'struct timespec' will not be visible outside of this function [-Werror,-Wvisibility]
40 extern void timespecsub(struct timespec *a, struct timespec *b,
43 Change-Id: Icc30a25c30fc606f46def07704cdc6997018d58f
45 2019-09-10 Sami Kerola <kerolasa@iki.fi>
47 ninfod: retire gettimeofday() in favor of clock_gettime()
49 Apply to ninfod similar fix as da9a6105b2cab2f92135a282d00cc939760e64c0.
51 Discussion about this and the next change spanned over several pull
52 requests that are mentioned below.
54 Reference: https://github.com/iputils/iputils/pull/213
55 Reference: https://github.com/iputils/iputils/pull/214
56 Reference; https://github.com/iputils/iputils/pull/215
57 Acked-by: Petr Vorel <petr.vorel@gmail.com>
59 2019-09-10 Sami Kerola <kerolasa@iki.fi>
61 common: make seeding pseudo-random number generator easy
63 Unify how srand() calls are done, with some care to try avoiding bad
64 seeding with hope pseudo-random numbers are unpredictable.
66 Acked-by: Petr Vorel <petr.vorel@gmail.com>
68 2019-06-10 Petr Vorel <petr.vorel@gmail.com>
70 common: move various fallback definitions into iputils_common.h
72 2019-03-25 Jan Tojnar <jtojnar@gmail.com>
74 doc: Use namespace correctly
76 The files declared xmlns:db but did not use the db namespace at all.
77 They did not define the default namespace at all, which coincidentally
78 worked with Docbook 4 stylesheets, making them think the files were
81 I fixed the namespaces of the documents and switched to the correct
82 Docbook 5 stylesheets.
84 2019-03-23 Sami Kerola <kerolasa@iki.fi>
86 common: use single ARRAY_SIZE definition across files
88 The ARRAY_SIZE is Rusty Russell’s version, that looks a bit more complicated
89 than the original, but there is a reason to that. This macro will ensure
90 macro is used properly, and fail compilation if it is not. See reference
91 link for further explanation.
93 Reference: http://zubplot.blogspot.com/2015/01/gcc-is-wonderful-better-arraysize-macro.html
95 2019-03-09 Sami Kerola <kerolasa@iki.fi>
97 documentation: fix various spelling typos
101 Reference: https://github.com/codespell-project/codespell
103 2019-02-03 Sami Kerola <kerolasa@iki.fi>
105 libcommon: add string to a number conversion function
107 Based on standard libc strtol(), but has convenience wrapping to catch
108 errors so that one can convert numbers with just a single function call.
110 2019-02-02 Sami Kerola <kerolasa@iki.fi>
112 clang scan-build: fix various build warning
114 arping: fix dereference of null pointer.
115 clockdiff: fix assigned value is garbage or undefined warnings.
116 ninfod: fix dead assignment and use of uninitialized argument value.
117 ping: fix dead assignment.
118 rarpd: fix uninitialized argument value.
119 rdisc: fix uninitialized argument value.
120 tracepath: fix dereference of null pointer.
122 2019-01-01 Sami Kerola <kerolasa@iki.fi>
124 rarpd: use libc function to run in the background
126 ninfod: check writing a pid file was successful
128 2019-01-01 Sami Kerola <kerolasa@iki.fi>
130 libcommon: check standard streams status at exit
132 Earlier commands happily successed when writing to standard out or error did
133 not work. Following demonstrates old and new behavior of all commands in
136 $ ping -c 1 127.0.0.1 > /dev/full ; echo $?
138 $ ping -c 1 127.0.0.1 > /dev/full ; echo $?
139 ./builddir/ping: write error: No space left on device
142 2018-12-22 Sami Kerola <kerolasa@iki.fi>
144 rarpd: use error() to report command errors
146 2018-12-22 Sami Kerola <kerolasa@iki.fi>
148 common: move error() portability go-around to common library
150 This allows use of error() in other programs. The static common library can
151 also be used for other utility functions in future.
153 2018-12-20 Sami Kerola <kerolasa@iki.fi>
155 man: reindent xml files
157 Due to great amount of change in this update normal review is not possible.
158 I used following to ensure there are no unexpected changes.
160 # Generate old manual pages.
161 git checkout origin/master
164 for i in builddir/doc/*; do man $i > a/${i##*/}; done
165 # Generate new manual pages.
166 git checkout <this-branch>
169 for i in builddir/doc/*; do man $i > b/${i##*/}; done
173 2018-12-20 Sami Kerola <kerolasa@iki.fi>
175 man: update to docbook 5
177 2018-12-20 Sami Kerola <kerolasa@iki.fi>
179 man: fix rarpd command name in synopsis
181 While going through this manual page I noticed --help output being
182 incomplete, so lets sort that out in same go.
184 2018-12-18 Sami Kerola <kerolasa@iki.fi>
186 localization: move nls headers to iputils_common.h
190 2018-10-03 Sami Kerola <kerolasa@iki.fi>
192 warnings: fix multiple errno printing format specifier issues
194 All of these report same warning:
195 ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
197 2018-10-03 Sami Kerola <kerolasa@iki.fi>
199 add version print out to remaining commands
201 For some reason version print out was not implemented in all commands. This
204 2018-10-03 Sami Kerola <kerolasa@iki.fi>
206 ping, rarpd, rdisc: remove historical no-op SA_INTERRUPT
208 The sigaction option SA_INTERRUPT has been no-op for long time.
210 Reference: https://lwn.net/Articles/229673/
212 2018-10-03 Sami Kerola <kerolasa@iki.fi>
214 usage: unify usage outputs, and improve their helpfulness
216 Just listing options, like ping(8) did, does not help users.
218 2018-10-03 Sami Kerola <kerolasa@iki.fi>
220 various: do not use kernel data types in userspace
222 It is long standing recommendation not to mix kernel and user space headers.
223 See reference for details.
225 Reference: https://lwn.net/Articles/113349/
227 2018-10-03 Sami Kerola <kerolasa@iki.fi>
229 docs: fix docbook xml expectations warnings
231 This version of xslproc:
234 Using libxml 20907, libxslt 10132-GITv1.1.32-3-g32c88216 and libexslt 820
235 xsltproc was compiled against libxml 20906, libxslt 10132 and libexslt 820
236 libxslt 10132 was compiled against libxml 20906
237 libexslt 820 was compiled against libxml 20906
239 Printed following warning at each manual page creation.
241 [17/25] Generating arping.8 with a custom command.
242 Note: meta source : no *info/productname or alternative arping
243 Note: meta source : see http://www.docbook.org/tdg5/en/html/produ arping
244 Note: meta source : no refentry/refmeta/refmiscinfo@class=source arping
245 Note: meta source : see http://www.docbook.org/tdg5/en/html/refmi arping
246 Note: meta version: no *info/productnumber or alternative arping
247 Note: meta version: see http://www.docbook.org/tdg5/en/html/produ arping
248 Note: meta version: no refentry/refmeta/refmiscinfo@class=version arping
249 Note: meta version: see http://www.docbook.org/tdg5/en/html/refmi arping
250 Warn: meta source : using "iputils" for "source" arping
252 2018-10-03 Sami Kerola <kerolasa@iki.fi>
254 warnings: fix multiple unused parameter warnings
256 This fixes multiple instances of unnused parameter warnings, that look like:
257 ping.c:1025:36: warning: unused parameter 'len' [-Wunused-parameter]
259 2018-10-03 Sami Kerola <kerolasa@iki.fi>
261 warnings: fix multiple signed and unsigned integer expressions
263 This fixes many many instances of the following warnings.
265 warning: comparison between signed and unsigned integer expressions
268 Unfortunately the fix includes lots of type casts. Each of them was
269 considered from overflow point of view, and will hopefully not cause any
272 2018-10-03 Sami Kerola <kerolasa@iki.fi>
274 warnings: fix rarpd variable initialisation
276 Refer struct field names in initialiser, and trust compilers to be standard
277 compliant and fill rest of the data with zeros. This fixes following
280 rarpd.c:307:4: warning: missing initializer for field 'lladdr' of 'struct
281 rarp_map' [-Wmissing-field-initializers]
283 2018-10-03 Sami Kerola <kerolasa@iki.fi>
285 warnings: add marker to implicit fallthrough
287 This fixes an implicit fallthrough warning, that looks like:
288 rarpd.c:483:41: warning: this statement may fall through [-Wimplicit-fallthrough=]
290 2018-10-03 Sami Kerola <kerolasa@iki.fi>
292 warnings: remove variable shadowing
294 This fixes multiple instances of variable shadowing warning, that look like:
295 warning: declaration of 'var' shadows a previous local [-Wshadow]
297 2017-08-05 David Heidelberg <david@ixit.cz>
299 doc: convert from converting SGML to XML
301 This work is mostly inspired by systemd manpages procedure creation. [1]
303 With this commit, you can freely throw SGML tools and you should be fine
308 Also, please don't be shy fix bugs, it will need more polishing!
310 [1] https://github.com/systemd/systemd/tree/master/man
312 Fixes bug: https://github.com/iputils/iputils/issues/1
313 Fixes bug: https://github.com/iputils/iputils/issues/27
315 2014-04-18 David Heidelberger <david.heidelberger@ixit.cz>
317 replace non-POSIX compilant caddr_t with char *
319 fix include paths, now compile with both glibc and musl
321 2012-01-09 YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
323 rarpd: Check return value of chdir().
325 2007-10-12 YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
327 [RARPD]: Fixed several signedness issues for char strings.
329 2007-04-04 YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
331 Fix white space errors.
333 2006-12-20 Mike Frysinger <vapier@gentoo.org>
335 [PATCH] Use socklen_t in all the right places.
337 2006-04-16 YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
339 Initial import of iputils
341 Obtained from <ftp://ftp.inr.ac.ru/ip-routing/iputils-ss020927.tar.gz>.