mpdreload: Fix batch deletion when there are still loads pending.

[mpdhacks.git] / mpdreload.pl

diff --git a/mpdreload.pl b/mpdreload.pl
index c82353eb3e91f435a7bc0103b00e2e5fa3de6691..66bb39d2ccffd48f5fd9f3f8557e2e0e28edd037 100755 (executable)
--- a/mpdreload.pl
+++ b/mpdreload.pl
@@ -1,6 +1,6 @@
 #!/usr/bin/env perl
 #
-# Copyright © 2019-2020 Nick Bowler
+# Copyright © 2019-2021 Nick Bowler
 #
 # Replace the current MPD play queue with a saved playlist, by rearranging
 # existing queue entries when possible.  This avoids losing the current
@@ -29,8 +29,8 @@ my $sock;
 # Returns a hash reference mapping filenames to an array reference listing
 # the queue IDs for that file in the current play queue.
 sub get_tracks_in_play_queue {
-       my %matches;
-       my $entry;
+       my (%matches, %idmap, $entry);
+       my $pos = -1;
 
        MPD::exec("playlistinfo");
        while (<$sock>) {
@@ -40,13 +40,15 @@ sub get_tracks_in_play_queue {
                if (/^(\w+): (.*)$/) {
                        if ($1 eq "file") {
                                $entry = $matches{$2} //= [];
+                               $pos++;
                        } elsif ($1 eq "Id") {
                                push @$entry, $2;
+                               $idmap{$2} = $pos;
                        }
                }
        }
 
-       return \%matches;
+       return (\%matches, \%idmap);
 }
 
 # Given an MPD playlist name, returns a reference to an array containing
@@ -121,21 +123,49 @@ $sock = MPD::connect();
 
 # Retrieve the current play queue and target play queue.
 MPD::run("tagtypes", "clear");
-my $current = get_tracks_in_play_queue();
+my ($current, $idmap) = get_tracks_in_play_queue();
 my $target = get_playlist_files($ARGV[0]);
 
+my $end_position = (keys %$current);
+my $num_added = 0;
+my $add_start;
+
+sub load_tracks($) {
+       my ($seq) = @_;
+
+       my $start = $add_start // $seq;
+       my $end = $seq+1;
+
+       my $add_position = $end_position;
+       MPD::exec("load", $ARGV[0], "$start:$end");
+       $end_position += $end - $start;
+       MPD::exec("move", "$add_position:$end_position", "$start")
+               if ($add_position != $start);
+
+       undef $add_start;
+}
+
 MPD::exec("command_list_begin");
 for (my $i = 0; $i < @$target; $i++) {
        my $f = $target->[$i];
        my $id = shift @{ $current->{$f} };
 
+       load_tracks($i - 1) if (defined $id and defined $add_start);
+
        if (defined $id) {
-               MPD::exec("moveid", $id, $i);
+               # Try not to move tracks already in the right place.
+               MPD::exec("moveid", $id, $i)
+                       if ($i != $idmap->{$id} + $num_added);
        } else {
-               MPD::exec("addid", $f, $i);
+               $add_start //= $i;
+               $num_added++;
        }
 }
 
-# Remove any tracks left from the old play queue.
-MPD::exec("deleteid", $_) foreach (map { @$_ } values %$current);
+# Now all unwanted tracks from the original playqueue have been moved to the
+# end and can be deleted all at once.
+
+my $pos = $add_start // @$target;
+MPD::exec("delete", $pos . ":") if map { @$_ } values %$current;
+MPD::exec("load", $ARGV[0], "$add_start:") if defined $add_start;
 MPD::run("command_list_end");