libcdecl: Avoid redundant string literal in yyerror.

[cdecl99.git] / src / parse.y

diff --git a/src/parse.y b/src/parse.y
index a386c086b9718abc413f515e5183008036ce3776..abfccd20a5accb80404c9e5d399eb528742552da 100644 (file)
--- a/src/parse.y
+++ b/src/parse.y
@@ -76,6 +76,7 @@ const char *cdecl__token_name(unsigned token);
 }
 
 %{
+static void yyerror(YYLTYPE *, yyscan_t, struct cdecl **, const char *);
 static void free_decl(struct cdecl *);
 
 static void free_declspec(struct cdecl_declspec *x)
@@ -141,15 +142,6 @@ void cdecl__free(struct cdecl *decl)
 {
        free_decl(decl);
 }
-
-static void
-yyerror(YYLTYPE *loc, yyscan_t scanner, struct cdecl **out, const char *err)
-{
-       if (strstr(err, "T_LEX_ERROR"))
-               return;
-
-       cdecl__err(CDECL_ENOPARSE, "%s", err);
-}
 %}
 
 %destructor { free($$); }            <strval>
@@ -254,9 +246,7 @@ semi: | T_SEMICOLON
 
 declaration: declspecs declarators semi {
        $$ = $2;
-
-       for (struct cdecl *i = $$; i; i = i->next)
-               i->specifiers = $1;
+       $$->specifiers = $1;
 };
 
 /*
@@ -616,3 +606,12 @@ const char *cdecl__token_name(unsigned token)
 {
        return yytname[YYTRANSLATE(token)];
 }
+
+static void
+yyerror(YYLTYPE *loc, yyscan_t scanner, struct cdecl **out, const char *err)
+{
+       if (strstr(err, yytname[YYTRANSLATE(T_LEX_ERROR)]))
+               return;
+
+       cdecl__err(CDECL_ENOPARSE, "%s", err);
+}