]> git.draconx.ca Git - rrace.git/commitdiff
Avoid uninitialized value error in help output.
authorNick Bowler <nbowler@draconx.ca>
Thu, 10 Mar 2022 03:53:18 +0000 (22:53 -0500)
committerNick Bowler <nbowler@draconx.ca>
Thu, 10 Mar 2022 03:53:18 +0000 (22:53 -0500)
Technically simply passing an unitialized (indeterminate) arg value
to the help_print_option function has undefined behaviour even though
it is only unset in cases where it will not actually be used by the
function.  But it is easy to just ensure it has a well-defined value.

src/motif.c

index 2d4fe94d0b1f1e5e8683cf803725c156c7daf531..be5900d7bcadc9ccc43965dc1d552bbdc2348fe0 100644 (file)
@@ -68,6 +68,7 @@ static void print_usage(FILE *f)
 
 static void print_help(void)
 {
+       struct lopt_help help = {0};
        const struct option *opt;
 
        print_usage(stdout);
@@ -75,8 +76,6 @@ static void print_help(void)
        putchar('\n');
        puts("Options:");
        for (opt = lopts; opt->name; opt++) {
-               struct lopt_help help;
-
                if (!lopt_get_help(opt, &help))
                        continue;
                help_print_option(opt, help.arg, help.desc, 20);
@@ -104,7 +103,7 @@ static Widget early_setup(XtAppContext *app, int argc, char **argv)
                }
        }
 
-       shell = XtOpenApplication(app, PROGNAME, NULL, 0,
+       shell = XtOpenApplication(app, PACKAGE_TARNAME, NULL, 0,
                                  &argc, argv, (String *)default_resources,
                                  sessionShellWidgetClass, NULL, 0);