upkg: Use proper library routines in package_export.
authorNick Bowler <nbowler@draconx.ca>
Wed, 16 May 2012 00:23:43 +0000 (20:23 -0400)
committerNick Bowler <nbowler@draconx.ca>
Wed, 16 May 2012 00:23:43 +0000 (20:23 -0400)
Not sure why this function contained a complete re-implementation of
u_object_new_from_package, but here we are.  Call the appropriate
library function to eliminate a pile of code.

src/upkg.c

index 5a51c2e2203717e6eaa822a94aeb9c338ca092f9..176eca9ca491adc39a62c4e62104e5ff1600a412 100644 (file)
@@ -415,28 +415,13 @@ out:
 int package_export(GTypeModule *pkg)
 {
        struct upkg *upkg = U_PKG(pkg)->pkg;
-       const char *class, *package;
        GObject *obj;
-       GType type;
        int ret = 0;
 
        for (unsigned i = 0; i < upkg->export_count; i++) {
-               class = upkg_export_class(upkg, i, &package);
-               if (!class) {
-                       fprintf(stderr, "error getting class information.\n");
-                       return -1;
-               }
-
-               type = u_object_module_get_class(package, class);
-               if (!type)
-                       continue;
-
-               obj = g_object_new(type, NULL);
-               if (U_OBJECT_IS_EXPORTABLE(obj)) {
-                       if (u_object_deserialize(obj, upkg, i) != 0
-                           || export(pkg, obj, i) != 0) {
-                               ret = -1;
-                       }
+               obj = u_object_new_from_package(upkg, i);
+               if (U_OBJECT_IS_EXPORTABLE(obj) && export(pkg, obj, i) != 0) {
+                       ret = -1;
                }
                g_object_unref(obj);
        }