From: Nick Bowler <nbowler@draconx.ca>
Date: Fri, 25 Feb 2022 01:18:16 +0000 (-0500)
Subject: Fix awk usage in the testsuite.
X-Git-Url: https://git.draconx.ca/gitweb/gob-dx.git/commitdiff_plain/4ebed70c2119e843ce48ae4fa6076475d2100693

Fix awk usage in the testsuite.

We should be using the configure-detected $AWK in the testsuite to
ensure reasonable behaviour.  And remove the use of the GNU-specific
-N option, which appears to just be a mistake.
---

diff --git a/Makefile.am b/Makefile.am
index 3932dcb..8c084bc 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -209,6 +209,7 @@ atlocal: config.status
 	  printf ': "$${%s=%s}"\n' \
 	    CC '$(CC)' \
 	    CXX '$(CXX)' \
+	    AWK '$(AWK)' \
 	    CPPFLAGS '$(CPPFLAGS)' \
 	    CFLAGS '$(CFLAGS)' \
 	    CXXFLAGS '$(CXXFLAGS)' \
diff --git a/tests/general.at b/tests/general.at
index 624af5a..e35c578 100644
--- a/tests/general.at
+++ b/tests/general.at
@@ -1,4 +1,4 @@
-dnl Copyright © 2019-2021 Nick Bowler
+dnl Copyright © 2019-2022 Nick Bowler
 dnl License GPLv2+: GNU General Public License version 2 or any later version.
 dnl This is free software: you are free to change and redistribute it.
 dnl There is NO WARRANTY, to the extent permitted by law.
@@ -51,19 +51,19 @@ TEST_COMPILE_GOBJECT([str.c], [0], [], [stderr])
 mv stderr str_stderr
 
 # Check for correct diagnostic messages on the target lines...
-AT_CHECK([awk '/want a string/ { print NR }' "$str_gob" >str_lines])
+AT_CHECK([$AWK '/want a string/ { print NR }' "$str_gob" >str_lines])
 total=0
 exec 3<str_lines
 while read l <&3; do
   AS_VAR_ARITH([total], [1 + $total])
-  AT_CHECK([awk -v line="$l" -v file="$str_gob" -NF : \
+  AT_CHECK([$AWK -v line="$l" -v file="$str_gob" -F : \
     '$1 == file && $2 == line { exit 42 }' str_stderr], [42])
 done
 exec 3<&-
 AT_CHECK([test x"$total" = x"2"])
 
 TEST_COMPILE_GOBJECT([main.c], [0], [], [stderr])
-AT_CHECK([awk -NF : '$1 == "main.c" && $2 == "16" { exit 42 }' stderr], [42])
+AT_CHECK([$AWK -F : '$1 == "main.c" && $2 == "16" { exit 42 }' stderr], [42])
 
 AT_CHECK([$CC $CFLAGS $LDFLAGS $LIBGOBJECT_LIBS -o main str.o main.o])
 
diff --git a/tests/options.at b/tests/options.at
index f8d56e4..089a87e 100644
--- a/tests/options.at
+++ b/tests/options.at
@@ -1,4 +1,4 @@
-dnl Copyright © 2020-2021 Nick Bowler
+dnl Copyright © 2020-2022 Nick Bowler
 dnl License GPLv2+: GNU General Public License version 2 or any later version.
 dnl This is free software: you are free to change and redistribute it.
 dnl There is NO WARRANTY, to the extent permitted by law.
@@ -18,7 +18,7 @@ AT_SETUP([--version option])
 AT_KEYWORDS([option])dnl
 
 AT_CHECK([gob2 invalid-file.gob --version --invalid-option], [0], [stdout])
-AT_CHECK([awk 'NR == 1 { print $NF }' stdout], [0], [AT_PACKAGE_VERSION
+AT_CHECK([$AWK 'NR == 1 { print $NF }' stdout], [0], [AT_PACKAGE_VERSION
 ])
 
 AT_CLEANUP