X-Git-Url: https://git.draconx.ca/gitweb/cdecl99.git/blobdiff_plain/9abf0eb2e74d0fb3a4f652499571cb35697d3036..4251b4bd0087752ceddbf95a6a8c928ab2207844:/src/error.c

diff --git a/src/error.c b/src/error.c
index 8b9f04e..36e6366 100644
--- a/src/error.c
+++ b/src/error.c
@@ -19,9 +19,7 @@
 #include <config.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 #include <assert.h>
-#include <stdarg.h>
 
 #include "cdecl.h"
 #include "cdecl-internal.h"
@@ -29,7 +27,9 @@
 #include <glthread/lock.h>
 #include <glthread/tls.h>
 
-gl_once_define(static, tls_initialized);
+#include "errmsg.h"
+
+gl_once_define(static, tls_initialized)
 static gl_tls_key_t tls_key;
 
 struct err_state {
@@ -49,10 +49,26 @@ static void free_err(void *err)
 	free(err);
 }
 
+static void set_err(unsigned code, struct cdecl_error *err)
+{
+	static const char errmsgs[] = STRTAB_INITIALIZER;
+
+	switch (code) {
+	case CDECL__ENOMEM:
+		err->code = CDECL_ENOMEM;
+		break;
+	default:
+		err->code = CDECL_ENOPARSE;
+		break;
+	}
+
+	err->str = _(&errmsgs[code]);
+}
+
 static void initialize(void)
 {
 	cdecl__init_i18n();
-	err_no_mem.str = _("failed to allocate memory");
+	set_err(CDECL__ENOMEM, &err_no_mem);
 	gl_tls_key_init(tls_key, free_err);
 }
 
@@ -91,33 +107,35 @@ static struct err_state *get_err_state(void)
 }
 
 /*
- * cdecl__err(CDECL_ENOMEM);
- * cdecl__err(code, fmt, ...);
- *
- * Sets the library error to code, with a printf-style error string.
+ * Set the library error to one of the preset messages defined in errmsg.h
+ * (CDECL__Exxx).
  */
-void cdecl__err(unsigned code, ...)
+void cdecl__errmsg(unsigned msg)
 {
-	const char *fmt;
 	struct err_state *state;
-	int rc, try = 0;
-	va_list ap;
 
 	state = get_err_state();
 	if (!state)
 		return;
 
-	if (code == CDECL_ENOMEM) {
-		state->err.code = code;
-		state->err.str = err_no_mem.str;
+	set_err(msg, &state->err);
+}
+
+/*
+ * Sets the library error to code; fmt is a printf-style string that may use
+ * up to one %s directive, to refer to arg.
+ */
+void cdecl__err(unsigned code, const char *fmt, const char *arg)
+{
+	struct err_state *state;
+	int rc, try = 0;
+
+	state = get_err_state();
+	if (!state)
 		return;
-	}
-retry:
-	va_start(ap, code);
-	fmt = va_arg(ap, const char *);
-	rc = vsnprintf(state->str, state->nstr, fmt, ap);
-	va_end(ap);
 
+retry:
+	rc = snprintf(state->str, state->nstr, fmt, arg);
 	if (rc > 0 && rc >= state->nstr) {
 		assert(try++ == 0 && rc < SIZE_MAX / 4);
 		state = alloc_err_state(state, (size_t)(rc+1u) * 3 / 2);