X-Git-Url: https://git.draconx.ca/gitweb/cdecl99.git/blobdiff_plain/0b2a2978f09f5d9b56d8655dd60eaffbe9006b7a..898aa30bfb038ffeca54d6dea95f0f80fbc08f7f:/src/output.c

diff --git a/src/output.c b/src/output.c
index 27921ab..634b79e 100644
--- a/src/output.c
+++ b/src/output.c
@@ -1,6 +1,6 @@
 /*
  *  Helper functions for outputting text.
- *  Copyright © 2011, 2021, 2023 Nick Bowler
+ *  Copyright © 2011, 2021, 2023-2024 Nick Bowler
  *
  *  This program is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -17,43 +17,75 @@
  */
 #include <config.h>
 #include <stdio.h>
+#include <limits.h>
 #include <assert.h>
 
 #include "cdecl.h"
 #include "cdecl-internal.h"
 
+#include "parse.h"
 #include "specstr.h"
 
 size_t cdecl__advance(struct output_state *dst, size_t amount)
 {
-	if (amount >= dst->dstlen) {
-		dst->dstlen = 0;
-		dst->dst    = 0;
-	} else {
-		dst->dst    += amount;
-		dst->dstlen -= amount;
-	}
+	size_t x = MIN(amount, dst->dstlen);
+
+	dst->dst    += x;
+	dst->dstlen -= x;
+	dst->accum  += amount;
 
 	return amount;
 }
 
+size_t cdecl__strlcpy(char *dst, const char *src, size_t dstlen)
+{
+	size_t srclen = strlen(src);
+
+	if (dstlen > 0) {
+		memcpy(dst, src, MIN(dstlen, srclen+1));
+		if (dstlen <= srclen)
+			dst[dstlen-1] = 0;
+	}
+
+	return srclen;
+}
+
 size_t cdecl__emit(struct output_state *dst, const char *src)
 {
-	size_t rc = snprintf(dst->dst, dst->dstlen, "%s", src);
+	size_t rc = cdecl__strlcpy(dst->dst, src, dst->dstlen);
 	return cdecl__advance(dst, rc);
 }
 
-static size_t explain_spec(struct output_state *dst, struct cdecl_declspec *s)
+enum {
+	/*
+	 * upper bound on number of decimal digits required to convert
+	 * cdecl_uintmax.
+	 */
+	MAX_UINT_DIGITS = (CHAR_BIT * sizeof (cdecl_uintmax) + 2)/3
+};
+
+size_t cdecl__emit_uint(struct output_state *dst, cdecl_uintmax val)
 {
-	size_t ret;
+	char buf[MAX_UINT_DIGITS + 1], *p = &buf[sizeof buf];
 
-	ret = cdecl__emit(dst, spec_string(s->type));
-	if (s->ident) {
-		ret += cdecl__emit(dst, " " + !ret);
-		ret += cdecl__emit(dst, s->ident);
+	*(--p) = 0;
+	while (val > 0) {
+		*(--p) = '0' + val % 10;
+		val /= 10;
 	}
 
-	return ret;
+	return cdecl__emit(dst, p);
+}
+
+static void explain_spec(struct output_state *dst, struct cdecl_declspec *s)
+{
+	size_t rc;
+
+	rc = cdecl__emit(dst, spec_string(s->type));
+	if (s->ident) {
+		cdecl__emit(dst, " " + !rc);
+		cdecl__emit(dst, s->ident);
+	}
 }
 
 /*
@@ -61,19 +93,21 @@ static size_t explain_spec(struct output_state *dst, struct cdecl_declspec *s)
  * listed in mask, which is the bitwise OR of the desired specifier kinds, are
  * printed.
  */
-size_t cdecl__emit_specs(struct output_state *dst,
-                         struct cdecl_declspec *s,
-                         unsigned mask)
+const char *cdecl__emit_specs(struct output_state *dst,
+                              struct cdecl_declspec *s,
+                              unsigned mask)
 {
-	size_t ret = 0;
+	const char *sep = " ";
+	int empty = 1;
 
 	for (; s; s = s->next) {
 		if (!(s->type & mask))
 			continue;
 
-		ret += cdecl__emit(dst, " " + !ret);
-		ret += explain_spec(dst, s);
+		cdecl__emit(dst, sep + empty);
+		explain_spec(dst, s);
+		empty = 0;
 	}
 
-	return ret;
+	return sep + empty;
 }