X-Git-Url: https://git.draconx.ca/gitweb/cdecl99.git/blobdiff_plain/09d517aa84f99c3686803d156cde10fc0c02bdc2..23bee8f66fbd14c308d3c509a59024768bc2feef:/src/cdecl99.c

diff --git a/src/cdecl99.c b/src/cdecl99.c
index 5f60037..3eb7cc1 100644
--- a/src/cdecl99.c
+++ b/src/cdecl99.c
@@ -1,6 +1,6 @@
 /*
  * Command line utility for making sense of C declarations.
- * Copyright © 2011-2012, 2020-2023 Nick Bowler
+ * Copyright © 2011-2012, 2020-2024 Nick Bowler
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -37,6 +37,7 @@
 #include "xtra.h"
 #include "options.h"
 #include "version.h"
+#include "getline.h"
 
 #if HAVE_READLINE_READLINE_H
 #  include <readline/readline.h>
@@ -63,9 +64,8 @@ void print_error(const char *fmt, ...)
 {
 	va_list(ap);
 
-	if (batch_mode)
-		fprintf(stderr, "%s: ", progname);
-	fprintf(stderr, "%s", _("error: "));
+	fprintf(stderr, batch_mode ? "%s: %s" : "%.0s%s",
+	                progname, _("error: "));
 
 	va_start(ap, fmt);
 	vfprintf(stderr, fmt, ap);
@@ -105,10 +105,9 @@ static void print_help(const struct option *lopts)
 
 		help_print_option(opt, help.arg, help.desc, 20);
 	}
-	putchar('\n');
 
-	puts(_("For more information, see the cdecl99(1) man page."));
-	putchar('\n');
+	printf("\n%s\n\n",
+	       _("For more information, see the cdecl99(1) man page."));
 
 	/*
 	 * TRANSLATORS: Please add *another line* indicating where users should
@@ -117,21 +116,6 @@ static void print_help(const struct option *lopts)
 	printf(_("Report bugs to <%s>.\n"), PACKAGE_BUGREPORT);
 }
 
-static int do_getline(char **linebuf, size_t *n)
-{
-	ssize_t rc;
-
-	if ((rc = getline(linebuf, n, stdin)) < 0) {
-		if (ferror(stdin))
-			print_error("%s", strerror(errno));
-		return 0;
-	}
-
-	if (rc-- && (*linebuf)[rc] == '\n')
-		(*linebuf)[rc] = '\0';
-	return 1;
-}
-
 static int do_readline(char **linebuf, size_t *n, bool batch)
 {
 #if !HAVE_READLINE
@@ -158,7 +142,7 @@ static int repl(bool batch)
 {
 	char *line = NULL;
 	bool fail = 0;
-	size_t n;
+	size_t n = 0;
 
 	while (do_readline(&line, &n, batch)) {
 		int rc = run_command(line, batch);
@@ -246,8 +230,8 @@ static int initialize(int argc, char **argv)
 	}
 
 	if (optind < argc) {
-		fprintf(stderr, "%s: ", progname);
-		fprintf(stderr, _("excess command-line arguments:"));
+		fprintf(stderr, "%s: %s", progname,
+		                _("excess command-line arguments:"));
 		for (i = optind; i < argc; i++) {
 			fprintf(stderr, " %s", argv[i]);
 		}