2020-08-29 Nuno Silva common: fix infinite loop when getrandom fails Fixes: https://github.com/iputils/iputils/issues/291 2020-01-06 Sami Kerola common: flush streams before closing them On loaded systems slow tty can give false positive exit failure due pending bytes. Flush the streams that hopefully makes these problems less likely. Reference: https://github.com/iputils/iputils/commit/4655ecc5105c383669ef529f21f3344f99e7372f#commitcomment-36628770 2019-11-24 Sami Kerola rdisc / ninfod: fix format string warning warning: format string is not a string literal [-Wformat-nonliteral] The above was reported for rdisc.c lines 210 and 212, and ninfod/ninfod.c lines 162 and 165. Reviewed-by: Petr Vorel 2019-10-31 Philipp Kammerer doc: Proofreading rarpd.xml A few suggestions to make the manpage more easy to read 2019-10-17 Maciej Żenczykowski iputils_common.h: fix missing #include This fixes: In file included from ping/ping6_common.c:61: iputils_common.h:63:32: error: declaration of 'struct timespec' will not be visible outside of this function [-Werror,-Wvisibility] extern void timespecsub(struct timespec *a, struct timespec *b, ^ Change-Id: Icc30a25c30fc606f46def07704cdc6997018d58f 2019-09-10 Sami Kerola ninfod: retire gettimeofday() in favor of clock_gettime() Apply to ninfod similar fix as da9a6105b2cab2f92135a282d00cc939760e64c0. Discussion about this and the next change spanned over several pull requests that are mentioned below. Reference: https://github.com/iputils/iputils/pull/213 Reference: https://github.com/iputils/iputils/pull/214 Reference; https://github.com/iputils/iputils/pull/215 Acked-by: Petr Vorel 2019-09-10 Sami Kerola common: make seeding pseudo-random number generator easy Unify how srand() calls are done, with some care to try avoiding bad seeding with hope pseudo-random numbers are unpredictable. Acked-by: Petr Vorel 2019-06-10 Petr Vorel common: move various fallback definitions into iputils_common.h 2019-03-25 Jan Tojnar doc: Use namespace correctly The files declared xmlns:db but did not use the db namespace at all. They did not define the default namespace at all, which coincidentally worked with Docbook 4 stylesheets, making them think the files were written in Docbook 4. I fixed the namespaces of the documents and switched to the correct Docbook 5 stylesheets. 2019-03-23 Sami Kerola common: use single ARRAY_SIZE definition across files The ARRAY_SIZE is Rusty Russell’s version, that looks a bit more complicated than the original, but there is a reason to that. This macro will ensure macro is used properly, and fail compilation if it is not. See reference link for further explanation. Reference: http://zubplot.blogspot.com/2015/01/gcc-is-wonderful-better-arraysize-macro.html 2019-03-09 Sami Kerola documentation: fix various spelling typos Foudn with codespell. Reference: https://github.com/codespell-project/codespell 2019-02-03 Sami Kerola libcommon: add string to a number conversion function Based on standard libc strtol(), but has convenience wrapping to catch errors so that one can convert numbers with just a single function call. 2019-02-02 Sami Kerola clang scan-build: fix various build warning arping: fix dereference of null pointer. clockdiff: fix assigned value is garbage or undefined warnings. ninfod: fix dead assignment and use of uninitialized argument value. ping: fix dead assignment. rarpd: fix uninitialized argument value. rdisc: fix uninitialized argument value. tracepath: fix dereference of null pointer. 2019-01-01 Sami Kerola rarpd: use libc function to run in the background ninfod: check writing a pid file was successful 2019-01-01 Sami Kerola libcommon: check standard streams status at exit Earlier commands happily successed when writing to standard out or error did not work. Following demonstrates old and new behavior of all commands in this project. $ ping -c 1 127.0.0.1 > /dev/full ; echo $? 0 $ ping -c 1 127.0.0.1 > /dev/full ; echo $? ./builddir/ping: write error: No space left on device 1 2018-12-22 Sami Kerola rarpd: use error() to report command errors 2018-12-22 Sami Kerola common: move error() portability go-around to common library This allows use of error() in other programs. The static common library can also be used for other utility functions in future. 2018-12-20 Sami Kerola man: reindent xml files Due to great amount of change in this update normal review is not possible. I used following to ensure there are no unexpected changes. # Generate old manual pages. git checkout origin/master make clean && make mkdir a for i in builddir/doc/*; do man $i > a/${i##*/}; done # Generate new manual pages. git checkout make clean && make mkdir b for i in builddir/doc/*; do man $i > b/${i##*/}; done # Compare. diff -ruP a b 2018-12-20 Sami Kerola man: update to docbook 5 2018-12-20 Sami Kerola man: fix rarpd command name in synopsis While going through this manual page I noticed --help output being incomplete, so lets sort that out in same go. 2018-12-18 Sami Kerola localization: move nls headers to iputils_common.h Aboid boilerplating. 2018-10-03 Sami Kerola warnings: fix multiple errno printing format specifier issues All of these report same warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=] 2018-10-03 Sami Kerola add version print out to remaining commands For some reason version print out was not implemented in all commands. This fixes that. 2018-10-03 Sami Kerola ping, rarpd, rdisc: remove historical no-op SA_INTERRUPT The sigaction option SA_INTERRUPT has been no-op for long time. Reference: https://lwn.net/Articles/229673/ 2018-10-03 Sami Kerola usage: unify usage outputs, and improve their helpfulness Just listing options, like ping(8) did, does not help users. 2018-10-03 Sami Kerola various: do not use kernel data types in userspace It is long standing recommendation not to mix kernel and user space headers. See reference for details. Reference: https://lwn.net/Articles/113349/ 2018-10-03 Sami Kerola docs: fix docbook xml expectations warnings This version of xslproc: $ xsltproc --version Using libxml 20907, libxslt 10132-GITv1.1.32-3-g32c88216 and libexslt 820 xsltproc was compiled against libxml 20906, libxslt 10132 and libexslt 820 libxslt 10132 was compiled against libxml 20906 libexslt 820 was compiled against libxml 20906 Printed following warning at each manual page creation. [17/25] Generating arping.8 with a custom command. Note: meta source : no *info/productname or alternative arping Note: meta source : see http://www.docbook.org/tdg5/en/html/produ arping Note: meta source : no refentry/refmeta/refmiscinfo@class=source arping Note: meta source : see http://www.docbook.org/tdg5/en/html/refmi arping Note: meta version: no *info/productnumber or alternative arping Note: meta version: see http://www.docbook.org/tdg5/en/html/produ arping Note: meta version: no refentry/refmeta/refmiscinfo@class=version arping Note: meta version: see http://www.docbook.org/tdg5/en/html/refmi arping Warn: meta source : using "iputils" for "source" arping 2018-10-03 Sami Kerola warnings: fix multiple unused parameter warnings This fixes multiple instances of unnused parameter warnings, that look like: ping.c:1025:36: warning: unused parameter 'len' [-Wunused-parameter] 2018-10-03 Sami Kerola warnings: fix multiple signed and unsigned integer expressions This fixes many many instances of the following warnings. warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Unfortunately the fix includes lots of type casts. Each of them was considered from overflow point of view, and will hopefully not cause any issues. 2018-10-03 Sami Kerola warnings: fix rarpd variable initialisation Refer struct field names in initialiser, and trust compilers to be standard compliant and fill rest of the data with zeros. This fixes following compiler warning: rarpd.c:307:4: warning: missing initializer for field 'lladdr' of 'struct rarp_map' [-Wmissing-field-initializers] 2018-10-03 Sami Kerola warnings: add marker to implicit fallthrough This fixes an implicit fallthrough warning, that looks like: rarpd.c:483:41: warning: this statement may fall through [-Wimplicit-fallthrough=] 2018-10-03 Sami Kerola warnings: remove variable shadowing This fixes multiple instances of variable shadowing warning, that look like: warning: declaration of 'var' shadows a previous local [-Wshadow] 2017-08-05 David Heidelberg doc: convert from converting SGML to XML This work is mostly inspired by systemd manpages procedure creation. [1] With this commit, you can freely throw SGML tools and you should be fine with xsltproc :) Enjoy! Also, please don't be shy fix bugs, it will need more polishing! [1] https://github.com/systemd/systemd/tree/master/man Fixes bug: https://github.com/iputils/iputils/issues/1 Fixes bug: https://github.com/iputils/iputils/issues/27 2014-04-18 David Heidelberger replace non-POSIX compilant caddr_t with char * fix include paths, now compile with both glibc and musl 2012-01-09 YOSHIFUJI Hideaki rarpd: Check return value of chdir(). 2007-10-12 YOSHIFUJI Hideaki [RARPD]: Fixed several signedness issues for char strings. 2007-04-04 YOSHIFUJI Hideaki Fix white space errors. 2006-12-20 Mike Frysinger [PATCH] Use socklen_t in all the right places. 2006-04-16 YOSHIFUJI Hideaki Initial import of iputils Obtained from .