From: Nick Bowler <nbowler@draconx.ca>
Date: Wed, 10 Feb 2010 04:14:27 +0000 (-0500)
Subject: lbximg: Fix improper free.
X-Git-Url: http://git.draconx.ca/gitweb/liblbx.git/commitdiff_plain/e4d75d5e84c051b75bf6a81072734da22c44cb21

lbximg: Fix improper free.

We were freeing the row buffer twice on the error path, and not at all
on the success path.
---

diff --git a/src/lbximg.c b/src/lbximg.c
index d76346b..a2b7405 100644
--- a/src/lbximg.c
+++ b/src/lbximg.c
@@ -163,7 +163,6 @@ int outpng(unsigned int frameno,
 	}
 
 	if (setjmp(png_jmpbuf(png))) {
-		free(row);
 		png_destroy_write_struct(&png, &info);
 		goto err;
 	}
@@ -221,12 +220,11 @@ int outpng(unsigned int frameno,
 
 	png_destroy_write_struct(&png, &info);
 	fclose(of);
+	free(row);
 
 	if (verbose)
 		printf("wrote %s\n", name);
-
 	return 0;
-
 err:
 	fclose(of);
 	remove(name);